feat: support --config
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will that solve #39? |
|
No, but if you have an |
|
I don't know what the |
aladdin-add
requested changes
Oct 10, 2022
There was a problem hiding this comment.
Would it be possible to add some tests for this feature now, or does that have to wait for #16?
|
I think we need to wait for the e2e tests to be written and then test this uniformly. |
README.md
Outdated
Comment on lines
24
to
27
| npm init @eslint/config --config eslint | ||
| # or (`eslint-config` prefix is optional) | ||
| npm init @eslint/config --config eslint-config-eslint |
There was a problem hiding this comment.
Suggested change
| # use `eslint-config-eslint` shared config | |
| npm init @eslint/config --config eslint | |
| # or (`eslint-config` prefix is optional) | |
| npm init @eslint/config --config eslint-config-eslint | |
| # use `eslint-config-semistandard` shared config | |
| npm init @eslint/config --config semistandard | |
| # or (`eslint-config` prefix is optional) | |
| npm init @eslint/config --config eslint-config-semistandard |
I think eslint-config-eslint could be confusing. It might be better to use something like semistandard for the example?
README.md
Outdated
| npm init @eslint/config --config eslint,standard | ||
| # or | ||
| npm init @eslint/config --config eslint --config standard |
There was a problem hiding this comment.
This doesn't seem to work. I'm getting TypeError: argv.config.split is not a function because in this case argv.config is an array.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #23 #35